-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: external link will open in the same window #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ItshMoh, i don't think external link should open in the same window, instead we should let users know it opens a new window as indicated in the issue :)
Hey @AceTheCreator Do you want the message for opening to the new window like this. |
@ItshMoh, it doesn't have to be an alert, you can just add the warning message inside the title attribute like this: The warning will appear as tooltip when link is hovered over. |
Hey @AceTheCreator i have added the tooltip on hovering over the button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
/rtm |
🎉 This PR is included in version 2.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Now the external link will open in the same window.
Description
Related issue(s)
#962
video